Fix error counter in heat pump safety control#2015
Conversation
This way it won't overlap with the 'not' block
This block is already inherited from the base class
|
@FWuellhorst : I don't think the two events close to each other will pose an issue. I suggest we keep the counter always present as it is now. A future improvement could be to put |
|
Thanks for the adjustments. I further added revisions. Regarding |
|
The idea is to put the downstream safety blocks in parallel, and they all get the on signal as computed after the first block, or its bypass if the block is conditionally removed. |
Make safety checks run in parallel #2015
Closes #2011 .
@mwetter: The issue is valid for the other blocks, as well. Thus, I added the fix to the partial safety controller with error counter class.
I checked the examples and the counts look fine to me.


Only in the aggregated example, there sometimes is an increase in err for two components, e.g.
opeEnvErrandminFlowErr, see picture below.The event log shows two time events close to each other, see analysis:
I do think the new hys blocks could lead to more state events in a closed loop simulation, or do you think it makes no difference?
If it leads to more events, should I add a general
countErrorsBoolean to the safety blocks?